You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/16 14:20:39 UTC

[GitHub] [airflow] jhtimmins commented on a change in pull request #15158: Permission guard templated field rendering

jhtimmins commented on a change in pull request #15158:
URL: https://github.com/apache/airflow/pull/15158#discussion_r614876105



##########
File path: airflow/security/permissions.py
##########
@@ -32,6 +32,7 @@
 RESOURCE_JOB = "Jobs"
 RESOURCE_POOL = "Pools"
 RESOURCE_PLUGIN = "Plugins"
+RESOURCE_TEMPLATE_FIELD = "TemplateFields"

Review comment:
       ```suggestion
   RESOURCE_TEMPLATE_FIELD = "Template Fields"
   ```
   We've standardized around making the resource names human readable, since they are user facing.
   
   Can you also place this alphabetically in the list of resources?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org