[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

[GitBox <gi...@apache.org>]

mreutegg commented on code in PR #690:
URL: https://github.com/apache/jackrabbit-oak/pull/690#discussion_r966786563


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreStats.java:
##########
@@ -115,6 +152,29 @@ public class DocumentStoreStats implements DocumentStoreStatsCollector, Document
     private final TimerStats removeNodesTimer;
     private final MeterStats prefetchNodes;
     private final TimerStats prefetchNodesTimer;
+    private final MeterStats createSplitNodeWithThrottlingMeter;
+    private final MeterStats updateNodeRetryCountWithThrottlingMeter;
+    private final MeterStats updateNodeFailureWithThrottlingMeter;
+    private final MeterStats updateNodeWithThrottlingMeter;
+    private final TimerStats updateNodeWithThrottlingTimer;
+    private final MeterStats createNodeUpsertWithThrottlingMeter;
+    private final TimerStats createNodeUpsertWithThrottlingTimer;
+    private final MeterStats createNodeWithThrottlingMeter;
+    private final TimerStats createNodeWithThrottlingTimer;
+    private final MeterStats createJournalWithThrottling;
+    private final TimerStats createJournalWithThrottlingTimer;
+    private final MeterStats removeNodesWithThrottling;
+    private final TimerStats removeNodesWithThrottlingTimer;

Review Comment:
   These and a few other fields can be turned into local variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org