You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/05/24 15:35:39 UTC

Re: svn commit: r1126985 - /subversion/trunk/subversion/libsvn_client/deprecated.c

On May 24, 2011 7:37 AM, <rh...@apache.org> wrote:
>
> Author: rhuijben
> Date: Tue May 24 11:37:06 2011
> New Revision: 1126985
>
> URL: http://svn.apache.org/viewvc?rev=1126985&view=rev
> Log:
> Following up on r1126983, fix deprecated wrappers.

I see this, and think, "wow. r1126983 was committed without even
*compiling*, let alone running switch_tests or update_tests."

.......

Re: svn commit: r1126985 - /subversion/trunk/subversion/libsvn_client/deprecated.c

Posted by Stefan Sperling <st...@elego.de>.
On Tue, May 24, 2011 at 09:35:39AM -0400, Greg Stein wrote:
> On May 24, 2011 7:37 AM, <rh...@apache.org> wrote:
> >
> > Author: rhuijben
> > Date: Tue May 24 11:37:06 2011
> > New Revision: 1126985
> >
> > URL: http://svn.apache.org/viewvc?rev=1126985&view=rev
> > Log:
> > Following up on r1126983, fix deprecated wrappers.
> 
> I see this, and think, "wow. r1126983 was committed without even
> *compiling*, let alone running switch_tests or update_tests."

Bert said this on IRC:

<stsp> Bert, r1126983  misses updates to deprecated.c
<Bert> stsp: *nod* Just found that... Now I just have to find why my
local compiler didn't care.

Re: svn commit: r1126985 - /subversion/trunk/subversion/libsvn_client/deprecated.c

Posted by Greg Stein <gs...@gmail.com>.
On May 24, 2011 9:39 AM, "Mark Phippard" <ma...@gmail.com> wrote:
>
> On Tue, May 24, 2011 at 9:35 AM, Greg Stein <gs...@gmail.com> wrote:
> > On May 24, 2011 7:37 AM, <rh...@apache.org> wrote:
> >>
> >> Author: rhuijben
> >> Date: Tue May 24 11:37:06 2011
> >> New Revision: 1126985
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1126985&view=rev
> >> Log:
> >> Following up on r1126983, fix deprecated wrappers.
> >
> > I see this, and think, "wow. r1126983 was committed without even
> > *compiling*,
>
> Wasn't it JavaHL that failed to compile?  If we want developers to
> always compile the Java bindings then why don't we remove it as a
> separate build target and just make it part of our default?

deprecated.c

Re: svn commit: r1126985 - /subversion/trunk/subversion/libsvn_client/deprecated.c

Posted by Mark Phippard <ma...@gmail.com>.
On Tue, May 24, 2011 at 9:35 AM, Greg Stein <gs...@gmail.com> wrote:
> On May 24, 2011 7:37 AM, <rh...@apache.org> wrote:
>>
>> Author: rhuijben
>> Date: Tue May 24 11:37:06 2011
>> New Revision: 1126985
>>
>> URL: http://svn.apache.org/viewvc?rev=1126985&view=rev
>> Log:
>> Following up on r1126983, fix deprecated wrappers.
>
> I see this, and think, "wow. r1126983 was committed without even
> *compiling*,

Wasn't it JavaHL that failed to compile?  If we want developers to
always compile the Java bindings then why don't we remove it as a
separate build target and just make it part of our default?

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/