You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/28 17:52:08 UTC
[GitHub] [camel] jeremyross opened a new pull request #4698: CAMEL-15904: camel-salesforce: streaming replayId default
jeremyross opened a new pull request #4698:
URL: https://github.com/apache/camel/pull/4698
Salesforce now requires a value for replayId, so defaulting to -1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jeremyross commented on a change in pull request #4698: CAMEL-15904: camel-salesforce: streaming replayId default
Posted by GitBox <gi...@apache.org>.
jeremyross commented on a change in pull request #4698:
URL: https://github.com/apache/camel/pull/4698#discussion_r532104506
##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceEndpointConfig.java
##########
@@ -166,8 +167,10 @@
private String instanceId;
// Streaming API properties
- @UriParam
- private Long defaultReplayId;
+ @UriParam(description = "Default replayId setting if no value is found in " +
+ "{@link #initialReplayIdMap}",
Review comment:
Ah, nice catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4698: CAMEL-15904: camel-salesforce: streaming replayId default
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4698:
URL: https://github.com/apache/camel/pull/4698#discussion_r532098873
##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceEndpointConfig.java
##########
@@ -166,8 +167,10 @@
private String instanceId;
// Streaming API properties
- @UriParam
- private Long defaultReplayId;
+ @UriParam(description = "Default replayId setting if no value is found in " +
+ "{@link #initialReplayIdMap}",
Review comment:
Can you remove this @link as this is not javadoc and we want to keep those descriptions just text based.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4698: CAMEL-15904: camel-salesforce: streaming replayId default
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4698:
URL: https://github.com/apache/camel/pull/4698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org