[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1823: [core] supports asynchronous deletion of expired snapshot files.

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1823:
URL: https://github.com/apache/incubator-paimon/pull/1823#discussion_r1294779489


##########
paimon-common/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -194,6 +194,19 @@ public class CoreOptions implements Serializable {
                     .defaultValue(Duration.ofHours(1))
                     .withDescription("The maximum time of completed snapshots to retain.");
 
+    public static final ConfigOption<SnapshotExpireDeleteMode> SNAPSHOT_EXPIRE_MODE =

Review Comment:
   Maybe we don't need this.
   
   The concurrent deletion mode can be the default mode, which appears harmless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org