You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Dillon (JIRA)" <de...@geronimo.apache.org> on 2006/07/21 15:38:17 UTC

[jira] Created: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Use JLine API to get password interactivly when using shutdown
--------------------------------------------------------------

                 Key: GERONIMO-2216
                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: startup/shutdown
    Affects Versions: 1.2
            Reporter: Jason Dillon
         Assigned To: Jason Dillon
            Priority: Minor


Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.

JLine provides the ability to mask the input as it is read (or omit it all together):

 * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2216?page=comments#action_12426833 ] 
            
Matt Hogstrom commented on GERONIMO-2216:
-----------------------------------------

+1 ... this is a bug...go ahead and apply it.

> Use JLine API to get password interactivly when using shutdown
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2216
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Minor
>         Attachments: GERONIMO-2216.diff
>
>
> Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.
> JLine provides the ability to mask the input as it is read (or omit it all together):
>  * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Posted by "Kevan Miller (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2216?page=comments#action_12426839 ] 
            
Kevan Miller commented on GERONIMO-2216:
----------------------------------------

Well, it's kind of funky... Not 100% pure java (dynamically extracts a dll and loads it on windows machines). Supported platforms on their website says:

JLine should work on any Windows system, or any minimally compliant POSIX system (includling Linux and Macintosh OS X).

I have to assume that there are some environments/JRE's where this might not work...

> Use JLine API to get password interactivly when using shutdown
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2216
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Minor
>         Attachments: GERONIMO-2216.diff
>
>
> Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.
> JLine provides the ability to mask the input as it is read (or omit it all together):
>  * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2216?page=all ]

Jason Dillon updated GERONIMO-2216:
-----------------------------------

    Attachment: GERONIMO-2216.diff

Attached patch reworks the PasswordReader into an InputReader, which uses the JLine library to provide console access and masking for passwords.

Hooked up to the shutdown command and the related car deps, so running shutdown.sh w/o flags will result in something like:

{noformat}
Username: system
Password: *******
{noformat}

This works for unix systems, windows and when no supported terminal is detected, reverts to the default brute force method that existed in PasswordReader, which was incorporated into JLine w/version 0.9.9

This patch fixed the issue of parts of the password being displayed when entered too fast.


> Use JLine API to get password interactivly when using shutdown
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2216
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Minor
>         Attachments: GERONIMO-2216.diff
>
>
> Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.
> JLine provides the ability to mask the input as it is read (or omit it all together):
>  * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2216?page=comments#action_12426843 ] 
            
Jason Dillon commented on GERONIMO-2216:
----------------------------------------

Yup, there is probably some env where this won't work... but JLine can detect that and will revert to basically the same behavior as we had before... I clued them into out brute force method.

But, 99% of the time it will work... and in reality its more like 99.99% of the time, since almost everyone is on Linux, Windows or Mac OS X (or some other Unix).

> Use JLine API to get password interactivly when using shutdown
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2216
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Minor
>         Attachments: GERONIMO-2216.diff
>
>
> Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.
> JLine provides the ability to mask the input as it is read (or omit it all together):
>  * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2216) Use JLine API to get password interactivly when using shutdown

Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2216?page=comments#action_12426838 ] 
            
Jason Dillon commented on GERONIMO-2216:
----------------------------------------

I will commit tomorrow unless there are any objections.

> Use JLine API to get password interactivly when using shutdown
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2216
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2216
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Minor
>         Attachments: GERONIMO-2216.diff
>
>
> Sometimes when interactively entering a password for shutdown, if the password is typed too fast, some of the chars are visible for a brief period.
> JLine provides the ability to mask the input as it is read (or omit it all together):
>  * http://jline.sourceforge.net/#reading_password

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira