You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/23 13:17:49 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #7833: Remove super().__init__() call in backported hooks

potiuk commented on a change in pull request #7833: Remove super().__init__() call in backported hooks
URL: https://github.com/apache/airflow/pull/7833#discussion_r396442318
 
 

 ##########
 File path: backport_packages/setup_backport_packages.py
 ##########
 @@ -155,6 +156,11 @@ def pure_airflow_models_filter(node: LN, capture: Capture, filename: Filename) -
         """Check if select is exactly [airflow, . , models]"""
         return len([ch for ch in node.children[1].leaves()]) == 3
 
+    def remove_super_init_call(node: LN, capture: Capture, filename: Filename) -> None:
+        for ch in node.post_order():
+            if hasattr(ch, "value") and ch.value == "super":
 
 Review comment:
   can we have something else than super().init() removed here? I do not see check that it is actually an init() method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services