You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Bouschen (JIRA)" <ji...@apache.org> on 2009/09/11 21:36:57 UTC
[jira] Created: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
tck enhancement should make use of feature to enhance an entire directory
-------------------------------------------------------------------------
Key: JDO-639
URL: https://issues.apache.org/jira/browse/JDO-639
Project: JDO
Issue Type: Improvement
Components: tck2
Affects Versions: JDO 2 maintenance release 2
Reporter: Michael Bouschen
Assignee: Michelle Caisse
The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
- Property jdo.tck.pcclasses.sources is used when checking whether (re)enahceing is required. Maybe a pattern
org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
can be used instead of listing all the persistnt capable classes explicitly.
- Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattrern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769695#action_12769695 ]
Craig Russell commented on JDO-639:
-----------------------------------
> The variables jdo.tck.paclasses.sources and jdo.tck.pcclasses.sources are always used together (as a union of the two sets). Same for *.files. Would it be a good idea now to further simplify things by using only one variable (pcclasses) and note in a comment that it also contains paclasses?
Since they are always used together, I see no down side in combining them.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt, jdo-639.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michelle Caisse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michelle Caisse updated JDO-639:
--------------------------------
Attachment: enhance.txt
To supply directories as arguments to the enhancer, I made the following change to project.properties. The attached file shows the output with NPE for each of the .class files (total of 102).
jdo.tck.jdometadata.files = \
package.jdo \
org/apache/jdo/tck/ \
org/apache/jdo/tck/api/instancecallbacks/ \
org/apache/jdo/tck/pc/ \
org/apache/jdo/tck/pc/company/ \
org/apache/jdo/tck/pc/companyMapWithoutJoin/ \
org/apache/jdo/tck/pc/companyListWithoutJoin/ \
org/apache/jdo/tck/pc/order/ \
org/apache/jdo/tck/pc/fieldtypes/ \
org/apache/jdo/tck/pc/inheritance/ \
org/apache/jdo/tck/pc/instancecallbacks/ \
org/apache/jdo/tck/pc/lifecycle/ \
org/apache/jdo/tck/pc/mylib/ \
org/apache/jdo/tck/pc/newInstance/ \
org/apache/jdo/tck/pc/query/ \
org/apache/jdo/tck/pc/singlefieldidentity/ \
org/apache/jdo/tck/pc/shoppingcart/ \
org/apache/jdo/tck/pc/companyAnnotatedFC/ \
org/apache/jdo/tck/pc/companyAnnotatedPI/ \
org/apache/jdo/tck/pc/companyAnnotatedPC/ \
org/apache/jdo/tck/pc/companyAnnotatedJPA/
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michelle Caisse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michelle Caisse resolved JDO-639.
---------------------------------
Resolution: Fixed
Complete with revision 829438
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt, jdo-639.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769282#action_12769282 ]
Craig Russell commented on JDO-639:
-----------------------------------
The patch makes the tck much more readable/usable.
If there are any tweaks needed in future, let's address them then.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt, jdo-639.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757218#action_12757218 ]
Craig Russell commented on JDO-639:
-----------------------------------
This seems to capture the essence of the issue.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enahceing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistnt capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattrern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michelle Caisse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michelle Caisse updated JDO-639:
--------------------------------
Attachment: jdo-639.txt
The attached patch implements the changes as spec'ed. Enhancement and TCK run fine with these changes. However, note that with the **/*.java/class syntax, jdo.tck.pcclasses.sources contains some members of jdo.tck.paclasses.sources. Likewise, jdo.tck.pcclasses.files includes some members of jdo.tck.paclasses.files. This is because org/apache/jdo/tck/api/instancecallbacks/ includes both pcclasses and paclasses.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt, jdo-639.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michelle Caisse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760008#action_12760008 ]
Michelle Caisse commented on JDO-639:
-------------------------------------
The difference between the calls to the DataNucleus enhancer when specifying classes versus directories on the command line is that when specifying classes javax.jdo.Enhancer supplies the full path whereas when the directory is specified, javax.jdo.Enhancer supplies only the class name:
Original code listing each class:
[java] Enhancer adding class file org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppAddress.class.
...
Modified code listing directories:
[java] Enhancer adding jdo file package.jdo.
[java] Enhancer adding jdo file package.jdo.
[java] Enhancer adding class file InstanceLifecycleListenerClear$PC.class.
[java] Enhancer adding class file InstanceLifecycleListenerDelete$PC.class.
...
Also, in the original code all jdo files are listed before the class files, but rearranging the order does not cause a failure.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760106#action_12760106 ]
Craig Russell commented on JDO-639:
-----------------------------------
Assuming that Michelle's analysis is correct (without verifying anything), let me suggest that there are three bugs:
1. NPE instead of "you poor sod, the file name you gave me isn't accessible" in DataNucleus.
2. javax.jdo.Enhancer fails to pass full path name for the files.
3. EnhancerTest case didn't catch this error.
I will take the second and third errors.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Bouschen updated JDO-639:
---------------------------------
Description:
The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
- Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
can be used instead of listing all the persistent capable classes explicitly.
- Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
was:
The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
- Property jdo.tck.pcclasses.sources is used when checking whether (re)enahceing is required. Maybe a pattern
org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
can be used instead of listing all the persistnt capable classes explicitly.
- Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattrern could replace the list of class files.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-639) tck enhancement should make use of
feature to enhance an entire directory
Posted by "Michelle Caisse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769671#action_12769671 ]
Michelle Caisse commented on JDO-639:
-------------------------------------
The variables jdo.tck.paclasses.sources and jdo.tck.pcclasses.sources are always used together (as a union of the two sets). Same for *.files. Would it be a good idea now to further simplify things by using only one variable (pcclasses) and note in a comment that it also contains paclasses?
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt, jdo-639.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo files as an argument (see property jdo.tck.jdometadata.files in project.properties and maven.xml). The new enhancer invocation API allows to enhance all files of a given directory. We should investigate to make use of this feature in order to get rid of listing all the .jdo in the property jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into the identitytype specific subdirectories before running the enhancer. Maybe a similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.