You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/09/08 19:04:09 UTC
[jira] [Created] (CASSANDRA-3161) clean up read path
clean up read path
------------------
Key: CASSANDRA-3161
URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 1.0
As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3159 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3161) clean up read path
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101334#comment-13101334 ]
Sylvain Lebresne commented on CASSANDRA-3161:
---------------------------------------------
+1 on v2
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 3161-v2.txt, 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-3161) clean up read path
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reopened CASSANDRA-3161:
---------------------------------------
the versions/endpoints change breaks RangeSliceResponseResolver. v2 attached that reverts that part.
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3161) clean up read path
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101090#comment-13101090 ]
Sylvain Lebresne edited comment on CASSANDRA-3161 at 9/9/11 9:38 AM:
---------------------------------------------------------------------
+1. Cleanup is definitively needed in there.
was (Author: slebresne):
+1. Cleanup is definitively need in there.
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3161) clean up read path
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3161:
--------------------------------------
Description: As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one. (was: As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3159 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.)
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3161) clean up read path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101308#comment-13101308 ]
Hudson commented on CASSANDRA-3161:
-----------------------------------
Integrated in Cassandra #1096 (See [https://builds.apache.org/job/Cassandra/1096/])
cleanup read path (StorageProxy side)
patch by jbellis; reviewed by slebrense for CASSANDRA-3161
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1167254
Files :
* /cassandra/trunk/src/java/org/apache/cassandra/service/RowDigestResolver.java
* /cassandra/trunk/src/java/org/apache/cassandra/service/RowRepairResolver.java
* /cassandra/trunk/src/java/org/apache/cassandra/service/StorageProxy.java
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 3161-v2.txt, 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3161) clean up read path
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3161:
--------------------------------------
Attachment: 3161-v2.txt
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 3161-v2.txt, 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3161) clean up read path
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101090#comment-13101090 ]
Sylvain Lebresne commented on CASSANDRA-3161:
---------------------------------------------
+1. Cleanup is definitively need in there.
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3161) clean up read path
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-3161.
---------------------------------------
Resolution: Fixed
committed
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 3161-v2.txt, 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3161) clean up read path
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3161:
--------------------------------------
Attachment: 3161.txt
- updates comments in RowDigestResolver and RowRepairResolver
- removes unnecessary versions + endpoints lists from RRR
- moves fetchrows "helper" collections into the do/while loop, where possible (this is fine from a performance perspective since the overwhelmingly most frequent case is we only execute the loop body once); also renames commands->initialCommands and commandsToSend->commands, pre-sizes "rows" list to avoid re-allocating it, and sizes readCallbacks as well.
> clean up read path
> ------------------
>
> Key: CASSANDRA-3161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 3161.txt
>
>
> As CASSANDRA-3156, CASSANDRA-3158, CASSANDRA-3157 show, the read path has gotten a little crufty, especially with the introduction of short read protection. Time for some cleanup to reduce the chance of bugs and to make troubleshooting easier when we do have one.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira