You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2016/04/23 12:26:02 UTC

[06/10] couchdb commit: updated refs/heads/master to 82d2eb1

Remove superflous TODO, Re-enable all HTTP tests and ensure TODO is in place


Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/d61fdf2a
Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/d61fdf2a
Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/d61fdf2a

Branch: refs/heads/master
Commit: d61fdf2a60774cd161c7c453ccb398bd65853d08
Parents: b74598b
Author: sebastianro <se...@apache.org>
Authored: Thu Apr 14 17:58:00 2016 +0200
Committer: Jan Lehnardt <ja...@apache.org>
Committed: Sat Apr 23 12:25:33 2016 +0200

----------------------------------------------------------------------
 test/javascript/tests/changes.js    | 2 +-
 test/javascript/tests/http.js       | 3 ---
 test/javascript/tests/list_views.js | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb/blob/d61fdf2a/test/javascript/tests/changes.js
----------------------------------------------------------------------
diff --git a/test/javascript/tests/changes.js b/test/javascript/tests/changes.js
index d69b563..d312edc 100644
--- a/test/javascript/tests/changes.js
+++ b/test/javascript/tests/changes.js
@@ -637,7 +637,7 @@ couchTests.changes = function(debug) {
 
   db.bulkSave(makeDocs(0, 5));
 
-// TODO: as before tests: for n>1 you can't be sure all docs are there immediately - so either stick w/ -n 1 or implement check-wait-check
+// for n>1 you can't be sure all docs are there immediately - so either stick w/ -n 1 or implement check-wait-check or use the quorum (for now, the latter seems 2 suffice)
 
   req = CouchDB.request("GET", "/" + db.name + "/_changes");
   resp = JSON.parse(req.responseText);

http://git-wip-us.apache.org/repos/asf/couchdb/blob/d61fdf2a/test/javascript/tests/http.js
----------------------------------------------------------------------
diff --git a/test/javascript/tests/http.js b/test/javascript/tests/http.js
index 850d5f2..c781778 100644
--- a/test/javascript/tests/http.js
+++ b/test/javascript/tests/http.js
@@ -37,8 +37,6 @@ couchTests.http = function(debug) {
     xhr.getResponseHeader("Location"),
     "should include X-Forwarded-Host");
 
-// TODO: allow modifications or leave out
-/*
   run_on_modified_server([{
     section:"httpd",
     key:"x_forwarded_host",
@@ -52,7 +50,6 @@ couchTests.http = function(debug) {
         xhr.getResponseHeader("Location"),
         "should include X-Host");
     });
-*/
 
   // COUCHDB-708: newlines document names
   xhr = CouchDB.request("PUT", "/" + db_name + "/docid%0A/attachment.txt", {

http://git-wip-us.apache.org/repos/asf/couchdb/blob/d61fdf2a/test/javascript/tests/list_views.js
----------------------------------------------------------------------
diff --git a/test/javascript/tests/list_views.js b/test/javascript/tests/list_views.js
index 5c39d23..e255e15 100644
--- a/test/javascript/tests/list_views.js
+++ b/test/javascript/tests/list_views.js
@@ -216,7 +216,7 @@ couchTests.list_views = function(debug) {
   T(xhr.status == 200, "standard get should be 200");
   T(/head0123456789tail/.test(xhr.responseText));
 
-  // test that etags are available - actually they're not (yet): https://issues.apache.org/jira/browse/COUCHDB-2859
+  // TODO: test that etags are available - actually they're not (yet): https://issues.apache.org/jira/browse/COUCHDB-2859
   //var etag = xhr.getResponseHeader("etag");
   //xhr = CouchDB.request("GET", "/" + db_name + "/_design/lists/_list/basicBasic/basicView", {
   //  headers: {"if-none-match": etag}