[GitHub] [hadoop] umamaheswararao commented on pull request #2058: HDFS-15394. Add all available fs.viewfs.overload.scheme.target..impl classes in core-default.xml bydefault.

[GitBox <gi...@apache.org>]

umamaheswararao commented on pull request #2058:
URL: https://github.com/apache/hadoop/pull/2058#issuecomment-639987530


   I see this test is asserting xml vs config class. However, the idea is not to expose this configurations to users. I am building the key dynamically in using 
   final String fsImplConf = String.format(
             FsConstants.FS_VIEWFS_OVERLOAD_SCHEME_TARGET_FS_IMPL_PATTERN,
             uri.getScheme());
   They are not necessarily added in config class as they will not be useful.
   Let me think what other way we can handled with out exposing in config classes.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org