You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/12/28 18:36:29 UTC
[jira] Created: (CASSANDRA-656) remove DataInputBuffer
remove DataInputBuffer
----------------------
Key: CASSANDRA-656
URL: https://issues.apache.org/jira/browse/CASSANDRA-656
Project: Cassandra
Issue Type: Task
Components: Core
Reporter: Jonathan Ellis
Priority: Minor
Fix For: 0.9
in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-656) remove DataInputBuffer
Posted by "Todd Blose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795012#action_12795012 ]
Todd Blose commented on CASSANDRA-656:
--------------------------------------
patch attached. I left DataInputBuffer.java and DataInputBufferTest.java for now, but they can be removed.
> remove DataInputBuffer
> ----------------------
>
> Key: CASSANDRA-656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-656
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: CASSANDRA-656.patch
>
>
> in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-656) remove DataInputBuffer
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795041#action_12795041 ]
Hudson commented on CASSANDRA-656:
----------------------------------
Integrated in Cassandra #307 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/307/])
replace DataInputBuffer with ByteArrayInputStream/DataInputStream. patch by Todd Blose; reviewed by jbellis for
> remove DataInputBuffer
> ----------------------
>
> Key: CASSANDRA-656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-656
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Todd Blose
> Priority: Minor
> Fix For: 0.9
>
> Attachments: CASSANDRA-656.patch
>
>
> in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-656) remove DataInputBuffer
Posted by "Todd Blose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795015#action_12795015 ]
Todd Blose commented on CASSANDRA-656:
--------------------------------------
My apologies. I overlooked that. I had only been running the unit tests, but I'll make sure to run the system tests as well for changes I make in the future. Thanks!
> remove DataInputBuffer
> ----------------------
>
> Key: CASSANDRA-656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-656
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Todd Blose
> Priority: Minor
> Fix For: 0.9
>
> Attachments: CASSANDRA-656.patch
>
>
> in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-656) remove DataInputBuffer
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795013#action_12795013 ]
Jonathan Ellis commented on CASSANDRA-656:
------------------------------------------
Committed to trunk, thanks! do consider joining the other cassandra devs on irc.
BTW, the available() change needed to be
while (dis.available() > 0)
the system tests caught this -- those are explained on http://wiki.apache.org/cassandra/HowToContribute
> remove DataInputBuffer
> ----------------------
>
> Key: CASSANDRA-656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-656
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: CASSANDRA-656.patch
>
>
> in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-656) remove DataInputBuffer
Posted by "Todd Blose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Blose updated CASSANDRA-656:
---------------------------------
Attachment: CASSANDRA-656.patch
> remove DataInputBuffer
> ----------------------
>
> Key: CASSANDRA-656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-656
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: CASSANDRA-656.patch
>
>
> in all (?) cases, DIB is replaceable with ByteArrayInputStream, which it wraps. use available() instead of getPosition().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.