[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#discussion_r1222689501


##########
datafusion/core/tests/sqllogictests/test_files/scalar.slt:
##########
@@ -911,17 +911,15 @@ SELECT not(true), not(false)
 ----
 false true
 
-query BB
+query error DataFusion error: Optimizer rule 'simplify_expressions' failed\ncaused by\nInternal error: NOT 'Literal \{ value: Int64\(1\) \}' can't be evaluated because the expression's type is Int64, not boolean or NULL\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker

Review Comment:
   It should fail in `type coercion`, it's a future ticket.
   We should try to cast param. (if fail cast then throw a error)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org