[jira] [Created] (STRATOS-625) Error in scale down logic

["Nirmal Fernando (JIRA)" <ji...@apache.org>]

Nirmal Fernando created STRATOS-625:
---------------------------------------

             Summary: Error in scale down logic 
                 Key: STRATOS-625
                 URL: https://issues.apache.org/jira/browse/STRATOS-625
             Project: Stratos
          Issue Type: Bug
          Components: Autoscaler
    Affects Versions: 4.0.0 Alpha
            Reporter: Nirmal Fernando
            Assignee: Nirmal Fernando
            Priority: Blocker
             Fix For: 4.0.0 RC1


Seems like following current scale down rule is not accurate.

scaleDown : Boolean() from ((rifReset && (rifPredictedValue < rifAverageLimit * 0.1)) || (mcReset && (mcPredictedValue < mcAverageLimit * 0.1)) || (laReset && (laPredictedValue < laAverageLimit * 0.1)))

Note the 'OR' conditions. If you read this, it'll mean that system would scale down if any of the factors resulted to drop down than its threshold, despite higher requests in one of the factors.

IMO we should use 'AND's instead of 'OR's.

Proposed fix:

scaleDown : Boolean() from ((rifReset && (rifPredictedValue < rifAverageLimit * 0.1)) && (mcReset && (mcPredictedValue < mcAverageLimit * 0.1)) && (laReset && (laPredictedValue < laAverageLimit * 0.1)))



--
This message was sent by Atlassian JIRA
(v6.2#6252)