You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "GlutenPerfBot (via GitHub)" <gi...@apache.org> on 2025/03/16 20:44:27 UTC

[PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

GlutenPerfBot opened a new pull request, #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017

   Upstream Velox's New Commits:
   
   ```txt
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017#issuecomment-2727638313

   https://github.com/apache/incubator-gluten/issues/6887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017#discussion_r2009542981


##########
.github/workflows/velox_backend.yml:
##########
@@ -240,7 +240,7 @@ jobs:
           else
             yum update -y && yum install -y java-1.8.0-openjdk-devel wget
           fi
-          yum install https://rpmfind.net/linux/almalinux/8.10/BaseOS/x86_64/os/Packages/tzdata-2024b-4.el8.noarch.rpm -y

Review Comment:
   > https://github.com/facebookincubator/velox/pull/12646 which requires the latest tzdata
   
   thanks for the fix, I encounter same issue when upgrade internal branch, but I'm still confused which line require latest tzdata, would you help explain more about the issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017#issuecomment-2734056405

   related:
   https://github.com/facebookincubator/velox/pull/12646 which requires the latest tzdata, however Centos7/8 does not provide the its necessary update. 
   "/usr/share/zoneinfo/Factory" is only available starts from Centos9
   this will introduce during Spark unit tests running:
   `org.apache.gluten.exception.GlutenException: basic_ios::clear: iostream`
   
   Velox should be patched to allow to use old version of tzdata
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017#discussion_r2001606478


##########
.github/workflows/velox_backend.yml:
##########
@@ -240,7 +240,7 @@ jobs:
           else
             yum update -y && yum install -y java-1.8.0-openjdk-devel wget
           fi
-          yum install https://rpmfind.net/linux/almalinux/8.10/BaseOS/x86_64/os/Packages/tzdata-2024b-4.el8.noarch.rpm -y

Review Comment:
   https://github.com/facebookincubator/velox/pull/12646 which requires the latest tzdata, however Centos7/8 does not provide the its necessary update.
   "/usr/share/zoneinfo/Factory" is only available starts from Centos9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017#discussion_r2009730568


##########
.github/workflows/velox_backend.yml:
##########
@@ -240,7 +240,7 @@ jobs:
           else
             yum update -y && yum install -y java-1.8.0-openjdk-devel wget
           fi
-          yum install https://rpmfind.net/linux/almalinux/8.10/BaseOS/x86_64/os/Packages/tzdata-2024b-4.el8.noarch.rpm -y

Review Comment:
   @Yohahaha 
   yes, here's the issue I fired in Velox
   https://github.com/facebookincubator/velox/issues/12721#issue-2931533237
   https://github.com/facebookincubator/velox/pull/12722



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_17) [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #9017:
URL: https://github.com/apache/incubator-gluten/pull/9017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org