[GitHub] [pinot] mayankshriv commented on a diff in pull request #9375: [multistage] add calcite function catalog

[GitBox <gi...@apache.org>]

mayankshriv commented on code in PR #9375:
URL: https://github.com/apache/pinot/pull/9375#discussion_r968656463


##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -86,6 +96,11 @@ public static void init() {
    */
   public static void registerFunction(Method method, boolean nullableParameters) {
     registerFunction(method.getName(), method, nullableParameters);
+
+    // Calcite ScalarFunctionImpl doesn't allow customized named functions. TODO: fix me.

Review Comment:
   What's the fix here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org