You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Viras- <gi...@git.apache.org> on 2017/05/01 10:21:35 UTC

[GitHub] cordova-plugin-file-transfer pull request #178: CB-12745: (iOS) Adding suppo...

GitHub user Viras- opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178

    CB-12745: (iOS) Adding support for non base64 encoded data-URIs

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adding support for non base64 encoded data-URIs
    
    ### What testing has been done on this change?
    Tested on iOS Simulator
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Viras-/cordova-plugin-file-transfer CB-12745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit fa6be13549b4234fca163fa74f51bc259506243d
Author: Viras- <vi...@users.sourceforge.net>
Date:   2017-05-01T10:20:35Z

    CB-12745: (iOS) Adding support for non base64 encoded data-URIs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: (iOS) Adding support for ...

Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
    Cordova CI Build has completed successfully.
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/178/commits/fa6be13549b4234fca163fa74f51bc259506243d)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/76/)
    
     318 tests run, 15 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
    Cordova CI Build has completed successfully.
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/178/commits/6d3379e935a37e6b4c77b000e6c270388cbe22ce)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/77/)
    
     318 tests run, 15 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

Posted by edu526 <gi...@git.apache.org>.
Github user edu526 commented on the issue:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
    Sorry, is this change available for use?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

Posted by Viras- <gi...@git.apache.org>.
Github user Viras- commented on the issue:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
    Are there any intentions on merging this pull or should I do it myself directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org