You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2008/01/30 17:56:35 UTC
[jira] Created: (DERBY-3365) Network Server stores a dupliacate
entry in the lob hash map for every lob
Network Server stores a dupliacate entry in the lob hash map for every lob
--------------------------------------------------------------------------
Key: DERBY-3365
URL: https://issues.apache.org/jira/browse/DERBY-3365
Project: Derby
Issue Type: Bug
Components: Network Server
Reporter: Kathey Marsden
Assignee: Kathey Marsden
Priority: Minor
Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564553#action_12564553 ]
Knut Anders Hatlen commented on DERBY-3365:
-------------------------------------------
Hmm, I guess your IDE or something must have tricked you into replacing (that is, removing + adding) EmbedBlob.java rather than modifying it. I managed to restore the file history by this sequence of commands:
$ cd java/engine/org/apache/derby/impl/jdbc
$ cp EmbedBlob.java EmbedBlob.java.old
$ svn remove EmbedBlob.java
$ svn copy -r 617185 EmbedBlob.java .
$ cp EmbedBlob.java.old EmbedBlob.java
$ svn ci
Now "svn annotate" shows the correct information, and not that all lines were changed by kmarsden in revision 617186. Hope I didn't break anything in the process...
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564373#action_12564373 ]
Knut Anders Hatlen commented on DERBY-3365:
-------------------------------------------
Looks fine to me. In BrokeredConnection, you should also remove the javadoc comment for addLOBMapping().
I'm wondering, should EngineBlob and EngineClob have been in iapi.jdbc rather than impl.jdbc? That's where the rest of the engine interfaces are located.
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564519#action_12564519 ]
Kathey Marsden commented on DERBY-3365:
---------------------------------------
Thanks Knut for looking at the patch. You are right about EngineClob and EngineBlob. Not sure how I managed to make them where I did, a matter of Eclipse making things too easy I think. I moved them before I committed.
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3365:
----------------------------------
Summary: Network Server stores a duplicate entry in the lob hash map for every lob (was: Network Server stores a dupliacate entry in the lob hash map for every lob)
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3365) Network Server stores a dupliacate
entry in the lob hash map for every lob
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3365:
----------------------------------
Attachment: derby-3365_stat.txt
derby-3365_diff.txt
Attached is a follow-up patch derby-3365_diff.txt incorporating review comments from my patch attached to DERBY-3243
(derby-3243_fix_double_hashmap_entry_diff.txt)
I'm sorry Knut I missed your original post about the patch.
Hopefully all the changes are in this time. For this revision I fixed the typos and changed the lob create stored procedures to use getLocator().
I did not move the addlobLocator call to getLocator() because it would cause a regression for the DERBY-2787 fix. I will leave any optimization in this area to the DERBY-3354 fix.
> Network Server stores a dupliacate entry in the lob hash map for every lob
> --------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564548#action_12564548 ]
Knut Anders Hatlen commented on DERBY-3365:
-------------------------------------------
Thanks Kathey. I noticed that the commit log looked a bit odd for this check-in. It says that EmbedBlob.java was added, and lists the entire file with plus lines in the diff. Do you know what happened?
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3365) Network Server stores a duplicate entry
in the lob hash map for every lob
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden closed DERBY-3365.
---------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
10.3.2.2
committed change to 10.3 and trunk.
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.2.2, 10.4.0.0
>
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3365) Network Server stores a duplicate
entry in the lob hash map for every lob
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564554#action_12564554 ]
Kathey Marsden commented on DERBY-3365:
---------------------------------------
Thanks Knut for fixing that up.
> Network Server stores a duplicate entry in the lob hash map for every lob
> -------------------------------------------------------------------------
>
> Key: DERBY-3365
> URL: https://issues.apache.org/jira/browse/DERBY-3365
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3365_diff.txt, derby-3365_stat.txt
>
>
> Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.