You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:24:53 UTC

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #6019: Add package definition on data collection protocol

kezhenxu94 edited a comment on issue #6019:
URL: https://github.com/apache/skywalking/issues/6019#issuecomment-746368691


   > What is the impact for current service?
   
   If the users code space contains class whose name is the same as what we defined in the protocol, it conflicts (maybe won't compile?), this was exactly what I encountered in the Python agent.
   
   In the Python agent, we solve this by generating the codes, and modifying its namespace (top package name in Python's term) to `skywalking`
   
   https://github.com/apache/skywalking-python/blob/f7f5aa77ace3f640fed3acaed9b7325a72c40a35/tools/codegen.py#L43-L49
   
   I am not sure whether this is feasible in C++.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org