You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/28 08:54:45 UTC
[GitHub] [spark] c21 commented on a change in pull request #29566: [SPARK-32629][SQL] Track metrics of BitSet/OpenHashSet in full outer SHJ
c21 commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478961374
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
@cloud-fan - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -136,10 +134,10 @@ case class ShuffledHashJoinExec(
* Full outer shuffled hash join with unique join keys:
* 1. Process rows from stream side by looking up hash relation.
* Mark the matched rows from build side be looked up.
- * A `BitSet` is used to track matched rows with key index.
+ * A [[BitSet]] is used to track matched rows with key index.
Review comment:
@cloud-fan - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -150,9 +148,9 @@ case class ShuffledHashJoinExec(
streamNullJoinRowWithBuild: => InternalRow => JoinedRow,
buildNullRow: GenericInternalRow,
streamNullRow: GenericInternalRow): Iterator[InternalRow] = {
- // TODO(SPARK-32629):record metrics of extra BitSet/HashSet
- // in full outer shuffled hash join
val matchedKeys = new BitSet(hashedRelation.maxNumKeysIndex)
+ val buildDataSize = longMetric("buildDataSize")
+ buildDataSize += matchedKeys.capacity / 8
Review comment:
@maropu - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org