You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/15 18:43:44 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…
michaeljmarshall opened a new pull request #12820:
URL: https://github.com/apache/pulsar/pull/12820
…eduplication
### Motivation
In https://github.com/apache/pulsar/pull/12493, we introduced potentially concurrent updates to the `inactiveProducers` map without any synchronization.
### Modifications
* Ensure that we only update the `inactiveProducers` map using proper synchronization.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
No breaking changes.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12820:
URL: https://github.com/apache/pulsar/pull/12820#issuecomment-969208639
@merlimat and @congbobo184 - PTAL. Based on https://github.com/apache/pulsar/pull/12493#discussion_r736742728, it looks like we prefer synchronization on the class as opposed to using a concurrent hash map. Let me know if my assumption here is correct, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12820:
URL: https://github.com/apache/pulsar/pull/12820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #12820:
URL: https://github.com/apache/pulsar/pull/12820#issuecomment-989769261
depends on #12493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12820:
URL: https://github.com/apache/pulsar/pull/12820#issuecomment-969259376
@merlimat I can include this patch in 2.9.0.
I was going to send out the VOTE but I can restart the procedure tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org