You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/05 01:33:07 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

ableegoldman opened a new pull request #8616:
URL: https://github.com/apache/kafka/pull/8616


   Copy of [pull/8540](https://github.com/apache/kafka/pull/8540) targeted at 2.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624270869


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624218152


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624208471






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-623792498


   @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-625971143


   Thanks @ableegoldman ! Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624859671


   @vvcephei  Both Java 11 builds passed, Java 8 failed with flaky 
   `DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners`
   `BranchedMultiLevelRepartitionConnectedTopologyTest.testTopologyBuild`
   
   (the Streams one is not related, it was converted to a unit test to reduce flakiness but that PR was not backported to 2.4)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624218222


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org