You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:10:25 UTC

[GitHub] [shardingsphere] jiangML opened a new pull request, #23194: Agent: optimize AgentClassloader

jiangML opened a new pull request, #23194:
URL: https://github.com/apache/shardingsphere/pull/23194

    Ref #23113
   
   Changes proposed in this pull request:
     - optimize `AgentClassloader`
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #23194: Agent: optimize AgentClassloader

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #23194:
URL: https://github.com/apache/shardingsphere/pull/23194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #23194: Agent: optimize AgentClassloader

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23194:
URL: https://github.com/apache/shardingsphere/pull/23194#issuecomment-1367775972

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23194](https://codecov.io/gh/apache/shardingsphere/pull/23194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fda905e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d719c4e74a79bde49141a796c693cf1af8360b4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d719c4e) will **increase** coverage by `0.00%`.
   > The diff coverage is `22.22%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #23194   +/-   ##
   =========================================
     Coverage     49.79%   49.79%           
     Complexity     2442     2442           
   =========================================
     Files          4013     4014    +1     
     Lines         57386    57391    +5     
     Branches       9105     9109    +4     
   =========================================
   + Hits          28575    28578    +3     
   - Misses        26273    26276    +3     
   + Partials       2538     2537    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...phere/agent/core/classloader/AgentClassLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jbGFzc2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=) | `10.86% <0.00%> (-6.44%)` | :arrow_down: |
   | [...core/plugin/loader/AdvisorConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vbG9hZGVyL0Fkdmlzb3JDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ardingsphere/agent/core/logging/LoggerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9sb2dnaW5nL0xvZ2dlckZhY3RvcnkuamF2YQ==) | `47.50% <50.00%> (ø)` | |
   | [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   | [...he/shardingsphere/infra/hint/SQLHintTokenEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRUb2tlbkVudW0uamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/23194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `81.13% <0.00%> (+1.13%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org