You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ta...@apache.org on 2012/07/30 22:10:17 UTC

svn commit: r1367259 - in /activemq/activemq-cpp/trunk/activemq-cpp/src/main: activemq/transport/inactivity/ decaf/util/concurrent/atomic/

Author: tabish
Date: Mon Jul 30 20:10:17 2012
New Revision: 1367259

URL: http://svn.apache.org/viewvc?rev=1367259&view=rev
Log:
Some code cleanup and refactoring.

Modified:
    activemq/activemq-cpp/trunk/activemq-cpp/src/main/activemq/transport/inactivity/InactivityMonitor.cpp
    activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicBoolean.h
    activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicInteger.h
    activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicReference.h

Modified: activemq/activemq-cpp/trunk/activemq-cpp/src/main/activemq/transport/inactivity/InactivityMonitor.cpp
URL: http://svn.apache.org/viewvc/activemq/activemq-cpp/trunk/activemq-cpp/src/main/activemq/transport/inactivity/InactivityMonitor.cpp?rev=1367259&r1=1367258&r2=1367259&view=diff
==============================================================================
--- activemq/activemq-cpp/trunk/activemq-cpp/src/main/activemq/transport/inactivity/InactivityMonitor.cpp (original)
+++ activemq/activemq-cpp/trunk/activemq-cpp/src/main/activemq/transport/inactivity/InactivityMonitor.cpp Mon Jul 30 20:10:17 2012
@@ -212,12 +212,12 @@ InactivityMonitor::InactivityMonitor( co
 :   TransportFilter( next ), members( new InactivityMonitorData() ) {
 
     this->members->wireFormat = wireFormat;
-    this->members->monitorStarted = false;
-    this->members->commandSent = false;
-    this->members->commandReceived = true;
-    this->members->failed = false;
-    this->members->inRead = false;
-    this->members->inWrite = false;
+    this->members->monitorStarted.set(false);
+    this->members->commandSent.set(false);
+    this->members->commandReceived.set(true);
+    this->members->failed.set(false);
+    this->members->inRead.set(false);
+    this->members->inWrite.set(false);
     this->members->readCheckTime = 0;
     this->members->writeCheckTime = 0;
     this->members->initialDelayTime = 0;
@@ -231,12 +231,12 @@ InactivityMonitor::InactivityMonitor( co
 :   TransportFilter( next ), members( new InactivityMonitorData() ) {
 
     this->members->wireFormat = wireFormat;
-    this->members->monitorStarted = false;
-    this->members->commandSent = false;
-    this->members->commandReceived = true;
-    this->members->failed = false;
-    this->members->inRead = false;
-    this->members->inWrite = false;
+    this->members->monitorStarted.set(false);
+    this->members->commandSent.set(false);
+    this->members->commandReceived.set(true);
+    this->members->failed.set(false);
+    this->members->inRead.set(false);
+    this->members->inWrite.set(false);
     this->members->readCheckTime = 0;
     this->members->writeCheckTime = 0;
     this->members->initialDelayTime = 0;

Modified: activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicBoolean.h
URL: http://svn.apache.org/viewvc/activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicBoolean.h?rev=1367259&r1=1367258&r2=1367259&view=diff
==============================================================================
--- activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicBoolean.h (original)
+++ activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicBoolean.h Mon Jul 30 20:10:17 2012
@@ -36,6 +36,11 @@ namespace atomic {
 
         volatile int value;
 
+    private:
+
+        AtomicBoolean(const AtomicBoolean&);
+        AtomicBoolean& operator= (const AtomicBoolean&);
+
     public:
 
         /**

Modified: activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicInteger.h
URL: http://svn.apache.org/viewvc/activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicInteger.h?rev=1367259&r1=1367258&r2=1367259&view=diff
==============================================================================
--- activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicInteger.h (original)
+++ activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicInteger.h Mon Jul 30 20:10:17 2012
@@ -39,6 +39,11 @@ namespace atomic {
 
         volatile int value;
 
+    private:
+
+        AtomicInteger(const AtomicInteger&);
+        AtomicInteger& operator= (const AtomicInteger&);
+
     public:
 
         /**

Modified: activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicReference.h
URL: http://svn.apache.org/viewvc/activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicReference.h?rev=1367259&r1=1367258&r2=1367259&view=diff
==============================================================================
--- activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicReference.h (original)
+++ activemq/activemq-cpp/trunk/activemq-cpp/src/main/decaf/util/concurrent/atomic/AtomicReference.h Mon Jul 30 20:10:17 2012
@@ -32,13 +32,19 @@ namespace atomic {
      */
     template< typename T >
     class AtomicReference {
+    private:
 
         volatile void* value;
 
+    private:
+
+        AtomicReference(const AtomicReference&);
+        AtomicReference& operator= (const AtomicReference&);
+
     public:
 
         AtomicReference() : value( NULL ) {}
-        AtomicReference( T* value ) : value( (void*)value ) {}
+        AtomicReference(T* valu ) : value((void*)value) {}
 
         virtual ~AtomicReference() {}