[GitHub] [ratis] codings-dan commented on a change in pull request #614: RATIS-1540. Remove old PeerConfiguration API and change SetConfiguration

[GitBox <gi...@apache.org>]

codings-dan commented on a change in pull request #614:
URL: https://github.com/apache/ratis/pull/614#discussion_r817629327



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/PeerConfiguration.java
##########
@@ -63,10 +65,6 @@
     return Collections.unmodifiableMap(map);
   }
 
-  PeerConfiguration(Iterable<RaftPeer> peers) {
-    this(peers, Collections.emptyList());
-  }
-

Review comment:
       done

##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/RaftConfigurationImpl.java
##########
@@ -63,10 +63,6 @@ Builder setConf(PeerConfiguration conf) {
       return this;
     }
 
-    Builder setConf(Iterable<RaftPeer> peers) {
-      return setConf(new PeerConfiguration(peers));
-    }
-

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org