You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sihuazhou <gi...@git.apache.org> on 2018/03/01 06:37:09 UTC

[GitHub] flink pull request #5605: [FLINK-8817][Distributed Coordination] Decrement n...

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5605

    [FLINK-8817][Distributed Coordination] Decrement numPendingContainerRequests only when request container successfully

    ## What is the purpose of the change
    
    This PR address [FLINK-8817](https://issues.apache.org/jira/browse/FLINK-8817), We should decrement numPendingContainerRequests only when request container successfully. Otherwise, the re-requested container can be released.
    
    ## Brief change log
    
    - Decrement numPendingContainerRequests only when request container successfully
    
    ## Verifying this change
    
    This change is a trivial rework without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
        no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink fix_decremnt_numPendingContainerRequests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5605
    
----
commit 7f4bcfe5a74d69c9a6f68aab1621646cb73e8a0e
Author: sihuazhou <su...@...>
Date:   2018-03-01T06:33:51Z

    Decrement numPendingContainerRequests only when request container successfully.

----


---

[GitHub] flink pull request #5605: [FLINK-8817][Distributed Coordination] Decrement n...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou closed the pull request at:

    https://github.com/apache/flink/pull/5605


---

[GitHub] flink issue #5605: [FLINK-8817][Distributed Coordination] Decrement numPendi...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/5605
  
    @tillrohrmann Sorry for not notice of the increases in `requestYarnContainer`, I just closing this.


---

[GitHub] flink issue #5605: [FLINK-8817][Distributed Coordination] Decrement numPendi...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/5605
  
    Hi @tillrohrmann , Could you please have a look at this?


---