[GitHub] [kafka] guozhangwang commented on a diff in pull request #12670: KAFKA-14239: Merge StateRestorationIntegrationTest into RestoreIntegrationTest

[GitBox <gi...@apache.org>]

guozhangwang commented on code in PR #12670:
URL: https://github.com/apache/kafka/pull/12670#discussion_r978222365


##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -97,11 +102,13 @@ public class RestoreIntegrationTest {
 
     public static final EmbeddedKafkaCluster CLUSTER = new EmbeddedKafkaCluster(NUM_BROKERS);
 
+

Review Comment:
   Are these new lines intentional? If not could you revert them?



##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -156,14 +228,16 @@ public void shouldRestoreStateFromSourceTopic(final boolean stateUpdaterEnabled)
         final Properties props = props(stateUpdaterEnabled);
         props.put(StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG, StreamsConfig.OPTIMIZE);
 
-        // restoring from 1000 to 4000 (committed), and then process from 4000 to 5000 on each of the two partitions
+        // restoring from 1000 to 4000 (committed), and then process from 4000 to 5000

Review Comment:
   The newlines introduced below till line 496 seems to be auto from IDE, could you revert them if they are not intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org