You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/19 01:02:06 UTC
[GitHub] [spark] gengliangwang commented on a diff in pull request #36583: [SPARK-39211][SQL] Support JSON scans with DEFAULT values
gengliangwang commented on code in PR #36583:
URL: https://github.com/apache/spark/pull/36583#discussion_r876496238
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##########
@@ -419,7 +419,13 @@ class JacksonParser(
val row = new GenericInternalRow(schema.length)
var badRecordException: Option[Throwable] = None
var skipRow = false
-
+ // Apply default values from the column metadata to the initial row, if any.
+ if (schema.hasExistenceDefaultValues) {
+ for ((value: Any, i: Int) <- schema.existenceDefaultValues.zipWithIndex) {
Review Comment:
Will this be a perf regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org