You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/17 02:52:10 UTC
[GitHub] [apisix] 123liubao opened a new pull request #6634: refactor: move kubernetes configuration files to t/chaos.
123liubao opened a new pull request #6634:
URL: https://github.com/apache/apisix/pull/6634
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #6624
I have moved kubernetes configuration files to t/chaos, and updated the relative path of `config.yaml`.
If there is anything else that needs to be changes, please tell me, and I will change it.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 123liubao commented on a change in pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
123liubao commented on a change in pull request #6634:
URL: https://github.com/apache/apisix/pull/6634#discussion_r829638272
##########
File path: t/chaos/kubernetes/README.md
##########
@@ -25,16 +25,16 @@ There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../conf/config.yaml`
+- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../../../conf/config.yaml`
Review comment:
Do you mean that `README.md` and `service-monitor-for-prometheus.yaml` under kubernetes folder should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6634:
URL: https://github.com/apache/apisix/pull/6634#discussion_r829670660
##########
File path: t/chaos/kubernetes/README.md
##########
@@ -25,16 +25,16 @@ There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../conf/config.yaml`
+- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../../../conf/config.yaml`
Review comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 123liubao commented on a change in pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
123liubao commented on a change in pull request #6634:
URL: https://github.com/apache/apisix/pull/6634#discussion_r829638272
##########
File path: t/chaos/kubernetes/README.md
##########
@@ -25,16 +25,16 @@ There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../conf/config.yaml`
+- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../../../conf/config.yaml`
Review comment:
Do you mean that `README.md` and `service-monitor-for-prometheus.yaml` under kubernetes folder should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6634:
URL: https://github.com/apache/apisix/pull/6634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6634:
URL: https://github.com/apache/apisix/pull/6634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6634:
URL: https://github.com/apache/apisix/pull/6634#discussion_r829670660
##########
File path: t/chaos/kubernetes/README.md
##########
@@ -25,16 +25,16 @@ There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../conf/config.yaml`
+- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../../../conf/config.yaml`
Review comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6634: refactor: move kubernetes configuration files to t/chaos.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6634:
URL: https://github.com/apache/apisix/pull/6634#discussion_r828783311
##########
File path: t/chaos/kubernetes/README.md
##########
@@ -25,16 +25,16 @@ There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../conf/config.yaml`
+- use `etcd`, if there is no `etcd` service, please install and set etcd address in `../../../conf/config.yaml`
Review comment:
Let's remove unused files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org