[GitHub] [netbeans] neilcsmith-net commented on pull request #5379: Proposal to change `==` comparing constants with `equals`

["neilcsmith-net (via GitHub)" <gi...@apache.org>]

neilcsmith-net commented on PR #5379:
URL: https://github.com/apache/netbeans/pull/5379#issuecomment-1409012317

   @vieiro I meant exactly that - not sure I worded it well.  Let's -1 and close this as is then?
   
   A PR for this change, where it's provably a comparison on a String that's possibly not interned, and where that behaviour is wrong, would be good.  But then it also might be empty. :smile:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists