You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Purshotam Shah (JIRA)" <ji...@apache.org> on 2014/09/02 22:39:22 UTC
[jira] [Commented] (OOZIE-1973) ConcurrentModificationException in
Sharelib service
[ https://issues.apache.org/jira/browse/OOZIE-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118699#comment-14118699 ]
Purshotam Shah commented on OOZIE-1973:
---------------------------------------
There are tho issue here,
1. As you pointed out, getSystemLibJars will keep on adding duplicates OOZIE_COMMON_LIBDIR sharelib to launcher lib.
{code}
public List<Path> getSystemLibJars(String actionKey) throws IOException {
List<Path> returnList = new ArrayList<Path>();
// Sharelib map is empty means that on previous or startup attempt of
// caching launcher jars has failed.Trying to reload
if (isShipLauncherEnabled) {
if (launcherLibMap.isEmpty()) {
synchronized (ShareLibService.class) {
if (launcherLibMap.isEmpty()) {
updateLauncherLib();
}
}
}
returnList = launcherLibMap.get(actionKey);
}
if (actionKey.equals(JavaActionExecutor.OOZIE_COMMON_LIBDIR)) {
List<Path> sharelibList = getShareLibJars(actionKey);
if (sharelibList != null) {
returnList.addAll(sharelibList);
}
}
return returnList;
}
{code}
2. We may have a case where Oozie can submit job before ShareLibService is initialized and this may happen because CallableQueueService is initialized before ShareLibService.
I was trying to say that case 2 can be fixed by OOZIE-1932.
> ConcurrentModificationException in Sharelib service
> ---------------------------------------------------
>
> Key: OOZIE-1973
> URL: https://issues.apache.org/jira/browse/OOZIE-1973
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Fix For: 4.1.0
>
>
> {quote}
> 2014-08-14 07:45:37,227 WARN pool-2-thread-57 ActionStartXCommand - SERVER[] USER[] GROUP[-] TOKEN[] APP[] JOB[0000850-140814062742075-oozie-oozi-W] ACTION[0000850-140814062742075-oozie-oozi-W@action] Error starting
> action [enhance]. ErrorType [ERROR], ErrorCode [ConcurrentModificationException], Message [ConcurrentModificationException: null]
> org.apache.oozie.action.ActionExecutorException: ConcurrentModificationException: null
> at org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:401)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:930)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1085)
> at org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:228)
> at org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:63)
> at org.apache.oozie.command.XCommand.call(XCommand.java:283)
> at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:323)
> at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:252)
> at org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:174)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)
> Caused by: java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:559)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:650)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:641)
> at org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:835)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)