[GitHub] [spark] HyukjinKwon commented on a change in pull request #27903: [SPARK-31149][PySpark] PySpark job not killing Spark Daemon processes…

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27903: [SPARK-31149][PySpark] PySpark job not killing Spark Daemon processes…
URL: https://github.com/apache/spark/pull/27903#discussion_r392637669
 
 

 ##########
 File path: python/pyspark/daemon.py
 ##########
 @@ -100,7 +100,7 @@ def manager():
     def shutdown(code):
         signal.signal(SIGTERM, SIG_DFL)
         # Send SIGHUP to notify workers of shutdown
-        os.kill(0, SIGHUP)
+        os.kill(0, SIGTERM)
         sys.exit(code)
 
 Review comment:
   `SIGHUP` is supposed to gracefully kill workers, and the we kill gracefully the daemon via proper `sys.exit`. Can you elabourate the process termination behaviours before and after this fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org