You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Joseph Lynch (JIRA)" <ji...@apache.org> on 2019/01/07 03:14:00 UTC
[jira] [Updated] (CASSANDRA-14955) Documentation can be built
without nodetool by accident
[ https://issues.apache.org/jira/browse/CASSANDRA-14955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Lynch updated CASSANDRA-14955:
-------------------------------------
Description:
While [~mick@thelastpickle.com] was generating docs today we accidentally pushed empty nodetool docs because the {{make website}} target doesn't fail if nodetool fails to run. We believe that this is due to the line in [gen-nodetool-docs.py|https://github.com/apache/cassandra/blob/trunk/doc/gen-nodetool-docs.py#L39] which uses subprocess.call instead of check_call.
Let's make it so that if you try to build docs without nodetool being available the build should fail so that we cant make the same mistake again.
was:<filling in details in a second>
> Documentation can be built without nodetool by accident
> -------------------------------------------------------
>
> Key: CASSANDRA-14955
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14955
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joseph Lynch
> Priority: Minor
>
> While [~mick@thelastpickle.com] was generating docs today we accidentally pushed empty nodetool docs because the {{make website}} target doesn't fail if nodetool fails to run. We believe that this is due to the line in [gen-nodetool-docs.py|https://github.com/apache/cassandra/blob/trunk/doc/gen-nodetool-docs.py#L39] which uses subprocess.call instead of check_call.
> Let's make it so that if you try to build docs without nodetool being available the build should fail so that we cant make the same mistake again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org