[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

["Huaisi Xu (Code Review)" <ge...@cloudera.org>]

Hello Juan Yu, Internal Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2341

to review the following change.

Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()
......................................................................

IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

Some TimestampValue converting functions assume caller
ensures TimestampValue instance has a valid date or time
but that's not true. Change those functions to return
result in output parameter and return boolean to indicate
the conversion is good or not.

Change-Id: I7a68a1e14d9c4ee5d83da760d4d76c20c36bc359
(cherry picked from commit 47d8977f5976b9be405f44add966820138fbda6f)
Reviewed-on: http://gerrit.cloudera.org:8080/2195
Reviewed-by: Juan Yu <jy...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 02af7d30879e08b20df16b2fc4e3de7d06337d31)
---
M be/src/exprs/aggregate-functions.cc
M be/src/exprs/cast-functions.cc
M be/src/exprs/timestamp-functions.cc
M be/src/exprs/timestamp-functions.h
M be/src/runtime/timestamp-test.cc
M be/src/runtime/timestamp-value.h
M tests/data_errors/test_data_errors.py
7 files changed, 168 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/41/2341/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a68a1e14d9c4ee5d83da760d4d76c20c36bc359
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hx...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>