[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

[GitBox <gi...@apache.org>]

yjshen commented on a change in pull request #1682:
URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792532430



##########
File path: datafusion/src/physical_plan/metrics/aggregated.rs
##########
@@ -35,25 +35,31 @@ pub struct AggregatedMetricsSet {
     final_: Arc<std::sync::Mutex<Vec<ExecutionPlanMetricsSet>>>,
 }
 
+impl Default for AggregatedMetricsSet {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl AggregatedMetricsSet {
     /// Create a new aggregated set
-    pub(crate) fn new() -> Self {
+    pub fn new() -> Self {

Review comment:
       To create a memory-managed version of [`ShuffleWriter`](https://github.com/blaze-init/blaze-rs/blob/master/datafusion-ext/src/shuffle_writer_exec.rs#L457-L508), we need to expose these four APIs for dependent crate usage. 
   I'm not sure this should be in its own PR, or I can have it here since it is also metric-related. I can remove this if needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org