You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2013/06/18 11:30:20 UTC

[jira] [Commented] (BOOKKEEPER-630) Indentation is incorrect in net/DNS.java

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686526#comment-13686526 ] 

Flavio Junqueira commented on BOOKKEEPER-630:
---------------------------------------------

It is a bit odd to have files formatted differently, but I understand your motivation, Ivan. What I was thinking is that if we are to pull changes for that file in the future, we could reformat the patched java file when generating a bookkeeper patch. The patch would include the changes to the code plus any necessary format conversion. What do you think?
                
> Indentation is incorrect in net/DNS.java
> ----------------------------------------
>
>                 Key: BOOKKEEPER-630
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-630
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Priority: Trivial
>
> We didn't reformat the code before bringing it in from hadoop commons in the patch of BOOKKEEPER-618.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira