You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/05/11 13:23:13 UTC
Review Request 59177: CLI: Added Config class to manage the config
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This new class simplifies the management of the configuration file
given by the user; it loads the TOML file on initialization and
has one method for each element that the user can set.
Diffs
-----
src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
src/cli_new/lib/cli/config.py PRE-CREATION
Diff: https://reviews.apache.org/r/59177/diff/1/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 59177: CLI: Added Config class to manage the
config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/#review174702
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59177]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 11, 2017, 1:23 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59177/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 1:23 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new class simplifies the management of the configuration file
> given by the user; it loads the TOML file on initialization and
> has one method for each element that the user can set.
>
>
> Diffs
> -----
>
> src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
> src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
> src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
> src/cli_new/lib/cli/config.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59177/diff/1/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 59177: CLI: Added Config class to manage the
config file.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/#review176264
-----------------------------------------------------------
Ship it!
I am adding the JIRA issue, changing the summary slightly, and separating this out into two separate patches before committing.
src/cli_new/bin/main.py
Lines 62-63 (patched)
<https://reviews.apache.org/r/59177/#comment249637>
I am going to separate this change out into its own commit, but otherwise, this patch looks good now.
- Kevin Klues
On May 29, 2017, 12:36 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59177/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 12:36 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7582
> https://issues.apache.org/jira/browse/MESOS-7582
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new class simplifies the management of the configuration file
> given by the user; it loads the TOML file on initialization and
> has one method for each element that the user can set.
>
> This new class and its associated content is also given to the plugins
> at initialization so that they can read the user configuration and use
> it.
>
>
> Diffs
> -----
>
> src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
> src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
> src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
> src/cli_new/lib/cli/config.py PRE-CREATION
> src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
> src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448
>
>
> Diff: https://reviews.apache.org/r/59177/diff/2/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 59177: CLI: Added Config class to manage the
config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/
-----------------------------------------------------------
(Updated May 29, 2017, 12:36 p.m.)
Review request for mesos and Kevin Klues.
Bugs: MESOS-7582
https://issues.apache.org/jira/browse/MESOS-7582
Repository: mesos
Description
-------
This new class simplifies the management of the configuration file
given by the user; it loads the TOML file on initialization and
has one method for each element that the user can set.
This new class and its associated content is also given to the plugins
at initialization so that they can read the user configuration and use
it.
Diffs
-----
src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
src/cli_new/lib/cli/config.py PRE-CREATION
src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e
src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448
Diff: https://reviews.apache.org/r/59177/diff/2/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 59177: CLI: Added Config class to manage the
config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/#review174920
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59177]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2017, 1:59 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59177/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 1:59 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new class simplifies the management of the configuration file
> given by the user; it loads the TOML file on initialization and
> has one method for each element that the user can set.
>
> This new class and its associated content is also given to the plugins
> at initialization so that they can read the user configuration and use
> it.
>
>
> Diffs
> -----
>
> src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
> src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
> src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
> src/cli_new/lib/cli/config.py PRE-CREATION
> src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
> src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448
>
>
> Diff: https://reviews.apache.org/r/59177/diff/2/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 59177: CLI: Added Config class to manage the
config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/
-----------------------------------------------------------
(Updated May 15, 2017, 1:59 a.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Patch modified to resolve the comments I have received offline.
Repository: mesos
Description (updated)
-------
This new class simplifies the management of the configuration file
given by the user; it loads the TOML file on initialization and
has one method for each element that the user can set.
This new class and its associated content is also given to the plugins
at initialization so that they can read the user configuration and use
it.
Diffs (updated)
-----
src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da
src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7
src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb
src/cli_new/lib/cli/config.py PRE-CREATION
src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e
src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448
Diff: https://reviews.apache.org/r/59177/diff/2/
Changes: https://reviews.apache.org/r/59177/diff/1-2/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet