[GitHub] [airflow] bhirsz commented on a diff in pull request #26488: Change dataprep system tests assets

[GitBox <gi...@apache.org>]

bhirsz commented on code in PR #26488:
URL: https://github.com/apache/airflow/pull/26488#discussion_r974929576


##########
airflow/providers/google/cloud/hooks/dataprep.py:
##########
@@ -68,7 +80,7 @@ def get_jobs_for_job_group(self, job_id: int) -> dict[str, Any]:
         :param job_id: The ID of the job that will be fetched
         """
         endpoint_path = f"v4/jobGroups/{job_id}/jobs"
-        url: str = os.path.join(self._base_url, endpoint_path)
+        url: str = urljoin(self._base_url, endpoint_path)

Review Comment:
   That's actually a good idea to do! We use os.path or similar instead of urljoins for urls. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org