You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/19 07:01:33 UTC

[GitHub] zhreshold opened a new pull request #13686: [gluon][transform]fix unpicklable transform_first on windows

zhreshold opened a new pull request #13686: [gluon][transform]fix unpicklable transform_first on windows
URL: https://github.com/apache/incubator-mxnet/pull/13686
 
 
   ## Description ##
   Allow windows user to properly use `Dataset.transform_first` in combination with `num_workers > 0`
   The original problem is caused by nested function which cannot be pickled in `transform_first`
   
   Reproduceable following http://en.diveintodeeplearning.org/chapter_deep-learning-basics/fashion-mnist.html and set num_workers > 0 on windows machine
   
   - Removed nested function and use callable object instead.
   - Test case added
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services