[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4646: Add global settings for VM migration flags

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #4646:
URL: https://github.com/apache/cloudstack/pull/4646#discussion_r692737718



##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -422,6 +426,13 @@
                         "Indicates whether the host in down state can be put into maintenance state so thats its not enabled after it comes back.",
                         true, ConfigKey.Scope.Zone, null);
 
+    protected final ConfigKey<Integer> KvmVmMigrateSpeed = new ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_SPEED, "-1",
+            "set the vm migrate speed (in MiB/s) on KVM. By default, it will try to guess the speed of the guest network (in MBps).", true);
+    protected final ConfigKey<Integer> KvmVmMigrateDowntime = new ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_DOWNTIME, "-1",
+            "Sets maximum tolerable time in milliseconds for which the domain is allowed to be paused at the end of live migration on KVM.", true);
+    protected final ConfigKey<Integer> KvmVmMigratePauseAfter = new ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_PAUSE_AFTER, "-1",
+            "Set an upper limit in milliseconds for how long live migration on KVM should wait, at which point VM is paused and migration will finish quickly.  Less than 1 means disabled.", true);
+

Review comment:
       > I'd say in the libvirt guru or - resource, I'd say. But to tell you the truth, I really don't know. As they are used in the AgentManager, maybe there. But for sure these shouldn't be initialised in `ConfigurationManagerImpl.initMessageBusListener()`.
   > For vmware there are such `ConfigKey`'s stored in the `VmwareGuru` and in a `VmwareManager`. Both seem resonable. In the KVM case the `KVMGuru` (which actually should be in the kvm hypervisor plugin, soit).
   
   agree with @DaanHoogland 
   `KVMGuru` looks like better place.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org