[GitHub] [incubator-hudi] n3nash commented on a change in pull request #872: [HUDI-235] Fix scheduled compaction rollback in restore command

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #872: [HUDI-235] Fix scheduled compaction rollback in restore command
URL: https://github.com/apache/incubator-hudi/pull/872#discussion_r324295380
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
 ##########
 @@ -808,16 +808,12 @@ public void restoreToInstant(final String instantTime) throws HoodieRollbackExce
             instantsToStats.put(instant.getTimestamp(), statsForInstant);
             break;
           case HoodieTimeline.COMPACTION_ACTION:
-            if (instant.isRequested()) {
-              // TODO : Get file status and create a rollback stat and file
-              // TODO : Delete the .aux files along with the instant file, okay for now since the archival process will
-              // delete these files when it does not see a corresponding instant file under .hoodie
-              deleteRequestedCompaction(instant.getTimestamp());
 
 Review comment:
   Let's keep it for now, need to do more clean up around this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services