[GitHub] [incubator-doris] wangbo commented on a change in pull request #6270: [Improvement] spark load without agg and de/serialization

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #6270:
URL: https://github.com/apache/incubator-doris/pull/6270#discussion_r688193553



##########
File path: be/src/olap/push_handler.h
##########
@@ -190,6 +190,7 @@ class PushBrokerReader {
     OLAPStatus init(const Schema* schema, const TBrokerScanRange& t_scan_range,
                     const TDescriptorTable& t_desc_tbl);
     OLAPStatus next(ContiguousRow* row);
+    OLAPStatus fill_field_row(RowCursorCell* dst, const char* src,bool src_null, MemPool* mem_pool, FieldType type);

Review comment:
       may ```private ``` is enough?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org