You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ab...@apache.org on 2020/10/06 09:45:19 UTC

[hive] branch master updated: HIVE-24192: Properly log TaskExecutorService eviction details (#1519) (Panagiotis Garefalakis reviewed by Laszlo Bodor)

This is an automated email from the ASF dual-hosted git repository.

abstractdog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 33fc863  HIVE-24192: Properly log TaskExecutorService eviction details (#1519) (Panagiotis Garefalakis reviewed by Laszlo Bodor)
33fc863 is described below

commit 33fc86355ea0be9ba13b39dde733935ec007c64b
Author: Panagiotis Garefalakis <pg...@cloudera.com>
AuthorDate: Tue Oct 6 10:45:04 2020 +0100

    HIVE-24192: Properly log TaskExecutorService eviction details (#1519) (Panagiotis Garefalakis reviewed by Laszlo Bodor)
    
    Change-Id: I41aa759596ac8015f0db493e3835a87ed6825835
---
 .../org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java | 3 ++-
 llap-server/src/main/resources/llap-daemon-log4j2.properties         | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java b/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
index e44dd2c..44145d3 100644
--- a/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
+++ b/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
@@ -583,7 +583,8 @@ public class TaskExecutorService extends AbstractService
       if (LOG.isInfoEnabled()) {
         LOG.info("{} evicted from wait queue in favor of {} because of lower priority",
             evictedTask.getRequestId(), task.getRequestId());
-      } else if (LOG.isDebugEnabled()) { // detailed info about the decision
+      }
+      if (LOG.isDebugEnabled()) { // detailed info about the decision
         FragmentRuntimeInfo evictedInfo =
             evictedTask.getTaskRunnerCallable().getFragmentRuntimeInfo();
         FragmentRuntimeInfo taskInfo = task.getFragmentRuntimeInfo();
diff --git a/llap-server/src/main/resources/llap-daemon-log4j2.properties b/llap-server/src/main/resources/llap-daemon-log4j2.properties
index c61b901..7cf688d 100644
--- a/llap-server/src/main/resources/llap-daemon-log4j2.properties
+++ b/llap-server/src/main/resources/llap-daemon-log4j2.properties
@@ -100,11 +100,14 @@ appender.query-routing.routes.route-mdc.file-mdc.app.layout.type = PatternLayout
 appender.query-routing.routes.route-mdc.file-mdc.app.layout.pattern = %d{ISO8601} %5p [%t (%X{fragmentId})] %c{2}: %m%n
 
 # list of all loggers
-loggers = PerfLogger, EncodedReader, NIOServerCnxn, ClientCnxnSocketNIO, DataNucleus, Datastore, JPOX, HistoryLogger, LlapIoImpl, LlapIoOrc, LlapIoCache, LlapIoLocking, TezSM, TezSS, TezHC, LlapDaemon
+loggers = PerfLogger, EncodedReader, NIOServerCnxn, ClientCnxnSocketNIO, DataNucleus, Datastore, JPOX, HistoryLogger, LlapIoImpl, LlapIoOrc, LlapIoCache, LlapIoLocking, TezSM, TezSS, TezHC, LlapDaemon, TaskExecutorService
 
 logger.LlapDaemon.name = org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon
 logger.LlapDaemon.level = INFO
 
+logger.TaskExecutorService.name = org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService
+logger.TaskExecutorService.level = INFO
+
 # shut up the Tez logs that log debug-level stuff on INFO
 
 logger.TezSM.name = org.apache.tez.runtime.library.common.shuffle.impl.ShuffleManager.fetch