You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/24 13:24:12 UTC

[GitHub] [echarts] Bilge opened a new issue #14785: dispatchAction does not support component IDs

Bilge opened a new issue #14785:
URL: https://github.com/apache/echarts/issues/14785


   ### What problem does this feature solve?
   `dispatchAction` supports addressing series and data by _name_ but not by _id_.
   
   In the following excerpt from the documentation we can see it indexes and names of series and data, but not the _id_ of any of series.
   
   ![image](https://user-images.githubusercontent.com/470626/115957441-63518c00-a4fa-11eb-8b02-92c4d4b03d7e.png)
   
   This seems to be the case for all `dispatchAction` targets, including the `legendToggleSelect` API which I want to use, that supports `name` but not `id`.
   
   ![image](https://user-images.githubusercontent.com/470626/115957477-a875be00-a4fa-11eb-89d7-301418c923e3.png)
   
   This is despite the fact that the documentation explicitly states the ID can be used to address the component via the API.
   
   ![image](https://user-images.githubusercontent.com/470626/115957506-d0652180-a4fa-11eb-92c6-6b2795a70045.png)
   
   I deliberately do not want to give a name to my series because I do not want it visible in the legend. I want to control it separately via the API. Yet, I cannot address it via its ID, only by its name, even though giving it a name has side-effects.
   
   ### What does the proposed API look like?
   ```js
   dispatchAction({
       type: 'legendToggleSelect',
       id: 'seriesId',
   })
   ```
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-827310523






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-827310523


   Actually `legendToggleSelect` is dispatched to `legend` component, not series. So the `name` property is from `legend.data`. And default `legend.data` is comes from `series.name` not `series/id`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-827310523


   Actually `legendToggleSelect` action is dispatched to `legend` component, not series. So the `name` property should match `legend.data`. And default `legend.data` comes from `series.name` not `series.id`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-826092605


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
   
   You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-827310523


   Actually `legendToggleSelect` action is dispatched to `legend` component, not series. So the `name` property is from `legend.data`. And default `legend.data` is comes from `series.name` not `series/id`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-826092605


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
   
   You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-826291750


   First, you may define the name of the series and it does not have to be in the legend if you don't want to. Just don't put it inside `legend.data` will do.
   
   If you wish to use id, most likely you have to specify the id in the series otherwise you may not know the default logic of series id (in fact, it looks like `"\u0000Series Name\u00000"`). So that won't be much difference if you specify `id` or `seriesName`.
   
   I tried with `seriedId` and it does not work. I don't know why it is not supported by now. But if you still have this requirement, we can discuss it more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on issue #14785: dispatchAction does not support component IDs

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #14785:
URL: https://github.com/apache/echarts/issues/14785#issuecomment-826291750


   First, you may define the name of the series and it does not have to be in the legend if you don't want to. Just don't put it inside `legend.data` will do.
   
   If you wish to use id, most likely you have to specify the id in the series otherwise you may not know the default logic of series id (in fact, it looks like `"\u0000Series Name\u00000"`). So that won't be much difference if you specify `id` or `seriesName`.
   
   I tried with `seriedId` and it does not work. I don't know why it is not supported by now. But if you still have this requirement, we can discuss it more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org