You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by sy...@apache.org on 2003/09/07 23:30:24 UTC
cvs commit: cocoon-2.1/src/blocks/woody/java/org/apache/cocoon/woody/formmodel Repeater.java
sylvain 2003/09/07 14:30:24
Modified: src/blocks/woody/java/org/apache/cocoon/woody/formmodel
Repeater.java
Log:
Keep the current size if the size parameter is not present.
This almost avoids the need for <wt:repeater-size> (the only need I see is when rows are added client-side)
Revision Changes Path
1.9 +0 -2 cocoon-2.1/src/blocks/woody/java/org/apache/cocoon/woody/formmodel/Repeater.java
Index: Repeater.java
===================================================================
RCS file: /home/cvs/cocoon-2.1/src/blocks/woody/java/org/apache/cocoon/woody/formmodel/Repeater.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- Repeater.java 26 Aug 2003 13:55:46 -0000 1.8
+++ Repeater.java 7 Sep 2003 21:30:24 -0000 1.9
@@ -148,8 +148,6 @@
removeRow(i);
}
}
- } else {
- rows.clear();
}
// let the rows read their data from the request
Re: cvs commit: cocoon-2.1/src/blocks/woody/java/org/apache/cocoon/woody/formmodel
Repeater.java
Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Bruno Dumon wrote:
>On Sun, 2003-09-07 at 23:30, sylvain@apache.org wrote:
>
>
>>sylvain 2003/09/07 14:30:24
>>
>> Modified: src/blocks/woody/java/org/apache/cocoon/woody/formmodel
>> Repeater.java
>> Log:
>> Keep the current size if the size parameter is not present.
>> This almost avoids the need for <wt:repeater-size> (the only need I see is when rows are added client-side)
>>
>>
>
>Another case where it's needed is when you don't store the form instance server side, but rebuild it on every request.
>
Yep.
But in all flow-driven forms, the form instance persists across requests
and so it's not needed. That's to simplify this frequent (at least for
me) use case that I changed the behaviour. Note that in that case,
having a <wt:repeater-size> causes no harm, since its value equals the
repeater's size.
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance - http://www.orixo.com
Re: cvs commit:
cocoon-2.1/src/blocks/woody/java/org/apache/cocoon/woody/formmodel
Repeater.java
Posted by Bruno Dumon <br...@outerthought.org>.
On Sun, 2003-09-07 at 23:30, sylvain@apache.org wrote:
> sylvain 2003/09/07 14:30:24
>
> Modified: src/blocks/woody/java/org/apache/cocoon/woody/formmodel
> Repeater.java
> Log:
> Keep the current size if the size parameter is not present.
> This almost avoids the need for <wt:repeater-size> (the only need I see is when rows are added client-side)
>
Another case where it's needed is when you don't store the form instance
server side, but rebuild it on every request.
--
Bruno Dumon http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
bruno@outerthought.org bruno@apache.org