You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/30 17:32:38 UTC
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5157: Recognize nbjrt: protocol and locate JDK9+ src.zip
lkishalmi commented on code in PR #5157:
URL: https://github.com/apache/netbeans/pull/5157#discussion_r1059473233
##########
java/java.platform/src/org/netbeans/modules/java/platform/queries/PlatformSourceForBinaryQuery.java:
##########
@@ -94,24 +94,46 @@ public SourceForBinaryQueryImplementation2.Result findSourceRoots2(URL binaryRoo
this.cache.put (binaryRoot, res);
return res;
}
- String binaryRootS = binaryRoot.toExternalForm();
- if (binaryRootS.startsWith(JAR_FILE)) {
- if (binaryRootS.endsWith(RTJAR_PATH)) {
- //Unregistered platform
- String srcZipS = binaryRootS.substring(4,binaryRootS.length() - RTJAR_PATH.length()) + SRC_ZIP;
- try {
- URL srcZip = FileUtil.getArchiveRoot(new URL(srcZipS));
- FileObject fo = URLMapper.findFileObject(srcZip);
- if (fo != null) {
- return new UnregisteredPlatformResult (fo);
- }
- } catch (MalformedURLException mue) {
- Exceptions.printStackTrace(mue);
- }
- }
+ return searchUnregisteredPlatform(binaryRoot.toExternalForm());
+ }
+
+ static SourceForBinaryQueryImplementation2.Result searchUnregisteredPlatform(String binaryRootS) {
+ String srcZipS = null;
+ String srcZipIn = null;
+ if (binaryRootS.startsWith(JAR_FILE)) {
+ if (binaryRootS.endsWith(RTJAR_PATH)) {
Review Comment:
NetBeans Formatter needs one more level of indirection, as it currently uses the project's auxiliary properties directly. If I had time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists