You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/04/09 23:32:33 UTC

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15700


Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................

IMPALA-9596: deflake test_tpch_mem_limit_single_node

This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).

This revealed an actual bug in the ORC scanner, where
it was was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.

Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder.h
A testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
5 files changed, 32 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15700/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15700

to look at the new patch set (#3).

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................

IMPALA-9596: deflake test_tpch_mem_limit_single_node

This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).

This revealed an actual bug in the ORC scanner, where
it was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.

Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/collection-value-builder.h
A testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
6 files changed, 38 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15700/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG@16
PS1, Line 16: was was
> nit: typo
Done


http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h
File be/src/runtime/collection-value-builder.h:

http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h@65
PS1, Line 65: have_debug_action_
> What is the point of introducing a member for this?
Yeah I was concerned about adding overhead per collection. Updated a comment to explain this.


http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:

http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py@148
PS1, Line 148: with memory limits tuned for
             :     a 3-node HDFS minicluster
> This part of the comment is no longer true, right?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 16:55:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 02:32:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5660/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:13:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:13:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 3: Code-Review+2

Fixed the test failures, it was backend test that did not pass in a RuntimeState to the ColelctionValueBuilder. I think the changes are large enough to require a re-review


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:42:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................

IMPALA-9596: deflake test_tpch_mem_limit_single_node

This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).

This revealed an actual bug in the ORC scanner, where
it was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.

Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Reviewed-on: http://gerrit.cloudera.org:8080/15700
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Gabor Kaszab <ga...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/collection-value-builder.h
M be/src/runtime/row-batch-serialize-test.cc
A testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
7 files changed, 63 insertions(+), 52 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Gabor Kaszab: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5779/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Apr 2020 00:14:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5804/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:36:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5656/


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 10:18:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15700

to look at the new patch set (#4).

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................

IMPALA-9596: deflake test_tpch_mem_limit_single_node

This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).

This revealed an actual bug in the ORC scanner, where
it was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.

Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/collection-value-builder.h
M be/src/runtime/row-batch-serialize-test.cc
A testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
7 files changed, 63 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15700/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15700

to look at the new patch set (#2).

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................

IMPALA-9596: deflake test_tpch_mem_limit_single_node

This changes the test to use a debug action instead of
trying to hit the memory limit in the right spot, which
has tended to be flaky. This still exercises the error
handling code in the scanner, which was the original
point of the test (see IMPALA-2376).

This revealed an actual bug in the ORC scanner, where
it was not returning the error directly from
AssembleCollection(). Before I fixed that, the scanner
got stuck in an infinite loop when running the test.

Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/collection-value-builder.h
A testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-errors.test
D testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M tests/query_test/test_nested_types.py
5 files changed, 34 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15700/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15700/1//COMMIT_MSG@16
PS1, Line 16: was was
nit: typo


http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h
File be/src/runtime/collection-value-builder.h:

http://gerrit.cloudera.org:8080/#/c/15700/1/be/src/runtime/collection-value-builder.h@65
PS1, Line 65: have_debug_action_
What is the point of introducing a member for this?
Can't you do "!state->query_options().debug_action.empty()" here?
Is this a perf optimisation?


http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:

http://gerrit.cloudera.org:8080/#/c/15700/1/tests/query_test/test_nested_types.py@148
PS1, Line 148: with memory limits tuned for
             :     a 3-node HDFS minicluster
This part of the comment is no longer true, right?



-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 08:20:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 2:

This looks like a legit failure in a backend test. I need to investigate.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:19:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5809/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 20:27:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 1:

Do you think we should change other memory limit tests in the same way? For example tests/query_test/test_query_mem_limit.py.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 09:27:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5656/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 05:45:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5808/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 20:47:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 )

Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4678963c264b7c15fbac6f71721162b38676aa21
Gerrit-Change-Number: 15700
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 05:44:55 +0000
Gerrit-HasComments: No