[GitHub] [hudi] vinothchandar commented on a change in pull request #3694: [HUDI-2469] [Kafka Connect] Replace json based payload with protobuf for Transaction protocol.

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #3694:
URL: https://github.com/apache/hudi/pull/3694#discussion_r714740487



##########
File path: hudi-kafka-connect/src/main/resources/ControlMessage.proto
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.hudi.connect";
+option java_outer_classname = "ConnectControl";
+
+package connect;
+
+message ControlMessage {
+  EventType type = 1;

Review comment:
       we need a version field here?

##########
File path: packaging/hudi-kafka-connect-bundle/pom.xml
##########
@@ -30,6 +30,7 @@
     <properties>
         <checkstyle.skip>true</checkstyle.skip>
         <main.basedir>${project.parent.basedir}</main.basedir>
+        <proto.version>3.17.3</proto.version>

Review comment:
       Could nt we declare in the parent and inherit the version here? in the bundle?

##########
File path: hudi-kafka-connect/pom.xml
##########
@@ -63,6 +64,25 @@
                 <groupId>org.apache.rat</groupId>
                 <artifactId>apache-rat-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.github.os72</groupId>
+                <artifactId>protoc-jar-maven-plugin</artifactId>
+                <version>3.1.0.1</version>
+                <executions>
+                    <execution>
+                        <phase>generate-sources</phase>
+                        <goals>
+                            <goal>run</goal>
+                        </goals>
+                        <configuration>
+                            <protocVersion>3.1.0</protocVersion>

Review comment:
       should this be a variable as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org