You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/29 15:08:15 UTC
[GitHub] [druid] zachjsh opened a new pull request #11392: revert commons-io to 2.6
zachjsh opened a new pull request #11392:
URL: https://github.com/apache/druid/pull/11392
Revert commons-io dependency from 2.9.0 to 2.6. This was package was upgraded to 2.9 by dependabot, and caused issues with loading extensions. In particular, when using version 2.9, if an extension's directory is a symlink, then none of the jars contained within the directory are found, which results in failure when loading the extension. Filed a bug with the commons-io project, https://issues.apache.org/jira/browse/IO-741. We can upgrade this dependency when this issue is resolved.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11392: revert commons-io to 2.6
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11392:
URL: https://github.com/apache/druid/pull/11392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on a change in pull request #11392: revert commons-io to 2.6
Posted by GitBox <gi...@apache.org>.
zachjsh commented on a change in pull request #11392:
URL: https://github.com/apache/druid/pull/11392#discussion_r660799715
##########
File path: .github/dependabot.yml
##########
@@ -9,3 +9,5 @@ updates:
# pin ZooKeeper dependencies to 3.5.x
- dependency-name: "org.apache.zookeeper"
versions: "[3.6,)"
+ # Keep commons-io at 2.6 until https://issues.apache.org/jira/browse/IO-741 is resolved
+ - dependency-name: "commons-io:commons-io"
Review comment:
opened https://github.com/apache/druid/issues/11393 to track issue of adding integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11392: revert commons-io to 2.6
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11392:
URL: https://github.com/apache/druid/pull/11392#discussion_r660744329
##########
File path: .github/dependabot.yml
##########
@@ -9,3 +9,5 @@ updates:
# pin ZooKeeper dependencies to 3.5.x
- dependency-name: "org.apache.zookeeper"
versions: "[3.6,)"
+ # Keep commons-io at 2.6 until https://issues.apache.org/jira/browse/IO-741 is resolved
+ - dependency-name: "commons-io:commons-io"
Review comment:
Can we create a github issue for us to track adding an integration test with symlinks so that we can validate the version bump for commons-io works in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org