You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/14 15:22:45 UTC
[GitHub] [pulsar] Jason918 opened a new pull request #12797: [Issue 12796][broker] Fix replicator error with user defined ReplicatorPrefix
Jason918 opened a new pull request #12797:
URL: https://github.com/apache/pulsar/pull/12797
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fix #12796
### Motivation
Previously, we are using `producerName.split("\\.")[2]` to parse remoteClusters.
https://github.com/apache/pulsar/blob/ba5809553344f074c5dce15618a70f3b20d368c7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java#L131
producerName is in the format of "replicatorPrefix.localCluster", and the default replicatorPrefix is "pulsar.repl".
So if we change replicatorPrefix to some string does not contain '.' , the error in #12796 will occurs. And the replication will not work.
### Modifications
Use substring instead of split dots.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- testReplicatorProducerName
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
Bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #12797: [Issue 12796][broker] Fix replicator error with user defined ReplicatorPrefix
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12797:
URL: https://github.com/apache/pulsar/pull/12797#issuecomment-968770350
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #12797: [Issue 12796][broker] Fix replicator error with user defined ReplicatorPrefix
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12797:
URL: https://github.com/apache/pulsar/pull/12797#issuecomment-968452415
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #12797: [Issue 12796][broker] Fix replicator error with user defined ReplicatorPrefix
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12797:
URL: https://github.com/apache/pulsar/pull/12797#issuecomment-968312033
@Technoboy- @codelipenghui Please help review this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12797: [Issue 12796][broker] Fix replicator error with user defined ReplicatorPrefix
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12797:
URL: https://github.com/apache/pulsar/pull/12797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org